Giters

NaturalIntelligence / fast-xml-parser

Validate XML, Parse XML and Build XML rapidly without C/C++ based libraries and no callback.

Home Page:https://naturalintelligence.github.io/fast-xml-parser/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

XMLValidator does not give error if XML declaration is not at the starting of XML

asthaaaaaa opened this issue · comments

commented
  • Are you running the latest version?
  • Have you included sample input, output, error, and expected output?
  • Have you checked if you are using correct configuration?
  • Did you try online tool?

Description

Input

Try to validate this XML<note><?xml version="1.0" encoding="utf-8"?>test</note>

Code

XMLValidator.validate(`<note><?xml version="1.0" encoding="utf-8"?>test</note>`)

Output

XMLValidator returns true

expected data

XMLValidator.validate should return error with message XML declaration allowed only at the start of the document.
https://github.com/NaturalIntelligence/fast-xml-parser/blob/3c9e9fe4346a3c9924d4db45e60a7a29c565caac/src/validator.js#L206C46-L206C104

Additional Notes:

fast-xml-parser/src/validator.js

Line 204 in 3c9e9fe

const tagname = xmlData.substr(start, i - start);
is the Root cause of the issue, as start = i in our case and tagname become ""

Would you like to work on this issue?

  • Yes
  • No

Bookmark this repository for further updates. Visit SoloThought to know about recent features.

commented

We're glad you find this project helpful. We'll try to address this issue ASAP. You can vist https://solothought.com to know recent features. Don't forget to star this repo.