NationalGenomicsInfrastructure / ngi_reports

Code to generate reports for use by the NGI in SciLifeLab

Home Page:http://nationalgenomicsinfrastructure.github.io/ngi_reports/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Scale of coverage plot in IGN sample report

parlundin opened this issue · comments

The X-axis goes all the way to 700x when average coverage is only ~30x

This will be due to L241 of common/ign_sample_report.py which (ironically) tries to set a relevant x axis limit:

# Be intelligent about upper limit for coverage
cov_max_x = 60
try:
    if float(self.samples[sample_id]['median_insert_size']) > 30:
        cov_max_x = int(self.samples[sample_id]['median_insert_size']) * 2
    except KeyError:
        pass

Not quite sure what is wrong here, so will need to debug..

Also, fix the GC plot to always have 100% as the x max.

Move the code above into ngi_visualizations instead, as this is a more logical place for it.

@parlundin: Have I fixed these already? Plots look fine to me now..

Yes they look fine so guess you did.

Awesome.