NationalBankBelgium / stark

Modern client-side Web application framework based on Angular, Angular Material / Material Design, TypeScript, Redux, RxJS, ...

Home Page:https://stark.nbb.be

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

core: `StaticInjectorError` due to `@uirouter/core` update

SuperITMan opened this issue · comments

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

When building the showcase in "prod" mode then running server:prod, we get the following error when we access the application.
It seems there is an issue with the preloading states (starkPreloadingStateName).

Transition Rejection($id: 1 type: 6, message: The transition errored, detail: Error: StaticInjectorError[e]: 
  StaticInjectorError(Platform: core)[e]: 
    NullInjectorError: No provider for e!)"

This error appeared after a fix made for the issue: ui-router/core#822.
The fix has been made to improve support for Angular > v12.
We got the new version because of the dependencies of @uirouter/angular v5.0.0. It has the following dependencies:

  "dependencies": {
    "@uirouter/core": "^6.0.1",
    "@uirouter/rx": "^0.6.0"
  },

Fixing the version to "@uirouter/core":"9.0.9" in stark-core, besides @uirouter/angular seems to fix this issue.

Expected behavior

Fix production build based on Stark 10.x.

What is the motivation / use case for changing the behavior?

Environment


Angular version: 7.x
Stark version: 10.x

 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

Closed by #3604