Giters

NationalBankBelgium / stark

Modern client-side Web application framework based on Angular, Angular Material / Material Design, TypeScript, Redux, RxJS, ...

Home Page:https://stark.nbb.be

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ui: some tests related to angular2-text-mask are failing

SuperITMan opened this issue · comments

commented

I'm submitting a...


[X] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

After upgrade to Angular 12, following tests are failing in StarkInputMaskDirectivesModule

  • NumberMaskDirective > with ngModel > should refresh the mask whenever the configuration changes
  • TextMaskDirective > with ngModel > should refresh the mask whenever the configuration changes
  • TextMaskDirective > with ngModel > should show/hide the mask placeholders depending of the value of the 'guide' option
  • TimestampMaskDirective > with ngModel > should refresh the mask whenever the configuration changes

with following error:

Error: NG0100: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value: '12/3_/____'. Current value: '12-3_'.. Find more at https://angular.io/errors/NG0100

To not block the first part of the migration to Angular 12, the tests have been excluded and a // FIXME comment above each excluded test.

Expected behavior

No test should be excluded.

Environment


Angular version: 12.x