v4 upgrade ?
RoyiNamir opened this issue · comments
LOL, guess that will teach me to lock it to 3.x...
NativeScript Dom was locked to the peer depenancy; I have released v2.0.1 of it that removes that line...
@NathanaelA Short question , isn't the red warning is under nativescript-orientation? , however you did fix DOM. , but looking at the tree it doesn't seems that the red section is a child of DOM , but a child of orientation.
Am I looking at it wrongly ?
To be honest your interpretation of the picture is correct, and that threw me initially too -- because when looking at the package for NS-Orientation, it didn't have a peer dependency on anything. I knew I used it in one of my plugins when NS 3.x first came out, so it was a matter of looking at dependencies of NS-Orientation and seeing if they had peer set on them, and it ended up that NS-Dom was the culprit.
My guess to why:
NPM saw NS-Orientation has a direct dependency on NS-Dom, and NS-Dom has a peer dependency of NS 3.x -- so after it listed all the normal deps it resolved; it then listed the peer' dep's...