Add type-hints to source code

Question

Add type-hints to source code

NathanY3G opened this issue a year ago · comments

Please add type-hints to the source code. This should help to document the code and make it easier for both users and contributors.

Aaron Tulino · Answer 1 · Sun Mar 26 2023 14:08:03 GMT+0800 (China Standard Time)

Any way I can help with this?

Nathan Young · Answer 2 · Tue Mar 28 2023 01:11:33 GMT+0800 (China Standard Time)

Any way I can help with this?

Sure! The first pass is mostly done but if you are really keen then please let me know and we can share the work. It may not be the most interesting task but it should help everyone who is interested in this project 🙂

Aaron Tulino · Answer 3 · Tue Mar 28 2023 11:05:55 GMT+0800 (China Standard Time)

I've looked through the code but I think you've added hints to all the functions. Is there actually any more to do still?

Aaron Tulino · Answer 4 · Tue Mar 28 2023 12:20:25 GMT+0800 (China Standard Time)

I submitted #83, hopefully that helps

Nathan Young · Answer 5 · Thu Mar 30 2023 02:31:44 GMT+0800 (China Standard Time)

Thanks @aaronjamt for helping with this 🙂

P.S. GitHub automatically closed your PR before it was merged! I suspect this occurred because both of the branches were named the same. I created a new PR to include your changes. However, if you believe any of your commits are missing then please let me know.