Nano Adblocker / Defender for Chromium-based Edge issues megathread
jspenguin2017 opened this issue · comments
Nano Adblocker: https://microsoftedge.microsoft.com/addons/detail/epbkapkgcmdmfpogenoebpdeibmfinpf
Nano Defender: https://microsoftedge.microsoft.com/addons/detail/ijfkmnlofajajikjhfiigelipempcklj
Important: Both extensions are considered beta and may not work correctly. Be sure to report issues so they can be resolved, we can't fix issues that we aren't aware of!
@jspenguin2017 I understand, you will add nano defender too, if it is chromium base. When you add? People still waiting.
@seba2282 The insider extensions store is currently invite-only. I don't know when Microsoft will start to accept submissions.
@jspenguin2017, can you tell more details, how works that insider extension program? I saw Nano Adblocker.
@jspenguin2017, you said about extension insider store. Can you more details, how extensions start be in that? Nano Adblocker is. What with Nano Defender?
@seba2282 I got an invitation email from Microsoft for Nano Adblocker, but didn't get one for Nano Defender.
If you want informations, I know, Windows 10 19H1 will not have Edge on Chromium. Maybe will be in Windows 10 19H2. Important is, Windows 10 as separate will be on abonament or only with some services like xbox pass and office 365.
The install package of Chromium-based Edge leaked yesterday. You can test with that package. As the program has a switch to "install extensions from other sources", I think upload Nano adblocker/defender will only be useful for users who cannot access Google services, for example, users in mainland China.
@lychichem I'll wait for an official release to confirm.
@jspenguin2017 and you can't give new versions Nano Adblocker to actual Microsoft Edge?
@seba2282 For Chromium-based Edge, Microsoft will be managing the extensions for now. For legacy Edge, see my comment here: #40 (comment)
@jspenguin2017 it would be nice if support for older Edge could be maintained because, even though the new Edge will be out in a couple of weeks, it will be released as a preview which most regular users won't use. No one knows when the new Edge will be available as a stable build, it will probable be available either for the 1909 or 2003 Windows build, so 6 months or 1 year where regular users won't receive any new Nano Adblocker versions.
@ivanmestre If enough people want another build for legacy Edge, I will reconsider. Cast your vote by adding 👍 to the comment above.
@jspenguin2017 Thanks, also Nano Adblocker works great on the new Edge. Both the one in the Edge Insider Extensions page and the one on the Chrome Store. I believe they are the same extension, but the one on the Edge Insider page is an older build. I believe what Microsoft did was listing the extensions that are currently in the Microsoft Store for old Edge and publishing the Chrome version on the Insider page. I think that's the case because Nano Adblocker on the Microsoft Store on old Edge is version 0.0.85.0 and the one in the Edge Insider page on new Edge is version 1.0.0.77.
@jspenguin2017, Nano Adblocker will be continue for old MS Edge? Is few time before MS give final MS Edge Chromium-base.
@seba2282 I have explained it above: #253 (comment) #253 (comment)
Any information about few support for old Edge until time, when will be Final Edge Chromium?
There's only 4 upvotes on the post above, so chances are I won't release new builds for the old Edge.
The Chromium-based Edge should be ready in a few months, it's already out for public beta:
https://www.microsoftedgeinsider.com/en-us/download/
@jspenguin2017, you didn't think about people who hasn't GitHub accounts? I guess is more people, who like your Nano products and they won't have actual any insiders Edge or other insider products and they wait for final version as regular. You only look on people who active on GH. But on others who haven't accounts GH...
@seba2282 Obviously I'm not expecting hundreds of upvotes, even though most people don't have a GitHub account, 4 votes is still too little. I know the new Edge is not yet bundled with Windows, but people can just go download it, I don't see how is that a problem.
Please keep the Nano Adblocker for EgdeHTML up to date. The new Chromium based one is awful on any touch & pen devices. It may/will take a very long time to match the usability of the old Edge, if ever at all. Who knows what's going to happen with the new incarnation of Edge, where the old one is perfectly fine and way better. Thank you.
I'll reconsider once there's ~20 votes. There's about 140 Internet users for every 1 GitHub user, 20 votes equates to about 2800 Internet users, which seems reasonable.
Some work is needed on Edgyfy side. I need an up-to-spec polyfill for TextEncoder / TextDecoder.
Hello. When will the 1.00.104 version be available in the Microsoft store?
When @jspenguin2017 give update. So after 6-12 months. Because Edge Chromium will after that time as stable and integrate with Windows 10. Author still isn't interesting old Edge.
Sorry for true.
I'm talking about an update for the new edge because I use it since the day of the release for insiders.
Dear jspenguin2017, thank you for taking into consideration the option of updating the Nano Adblocker for EdgeHTML once there are 20 votes for it. Hopefully happens soon. I think Microsoft will never give up completely on EdgeHTML, at least not in the near future. I'm all Surface, same many of my friends and a proper touch & pen support is indispensable for us.
@gdata1 The extension store for the new Edge is fully managed by Microsoft, and I can't update the listing. Note that you can install extensions directly from the Chrome WebStore to get newer versions.
jspenguin2017 Do I understand that you can not tell Microsoft about the release of the new version?
@gdata1 I don't see a way beside emailing them. I highly doubt they read the emails though, chances are they are receiving thousands a day. You can try to contact them, their email address is edgeext@microsoft.com... I think... Not sure if the inbox is managed by a bot or a group of people.
@jspenguin2017 I sent them a letter. Will wait for a response from them
@jspenguin2017 For the new Edge came the update 1.00.104
@jspenguin2017, support for Edge with old source dead permanently with updates?
@seba2282 I have answered it here: #253 (comment)
Dear jspenguin2017, I cannot believe there are only 9 upvotes for an EdgeHTML update. The new Chromium Edge is a pile of crap on any Surface and it will take Microsoft years to make it work, or never at all. Hopefully they will realise it sooner than later and abandon it in favour or EdgeHTML. Please reconsider again your decision regarding EdgeHTML. Thank you very much for all your hard work you put in so far.
Well is better alternative for Ublock Origin and his fork. Named Adguard. Team Adguard care about users and update their Adblocker for MS Edge on old source. And they can. More devs Adblockers gone for easy way (chromium). Sorry for true @jspenguin2017.
@PeteAtGH Have you even tried the new Chromium Edge? It runs like butter.
@seba2282 Thank you for your advice but I know Adguard AdBlocker and used it for a while after uBlock Origin for EdgeHTML stopped updating. It's quite good, 2nd on my list behind Nano Adblocker. Let's hope Nano gets maintained after all at the mercy of the creator?
@jorgegonzalez Yes I have, it's awful, slow, resource hungry, almost non-existend touch and pen support, bad scrolling, crashing, drains battery in connected standby when left open, extensions don't update in the background like on EdgeHTML when closed, etc. Tested on various MS Surfaces all with LTE.
@PeteAtGH If you say so, but that has not been my experience.
Hum... Looks like gorhill added a fallback for text encoder, I should be able to roll out an update if everything goes as planned.
gorhill@295f08d
I'll need to wait until 1.18.18 though, so it's probably not happening within a few weeks.
Dear @jspenguin2017, it's much appreciated, thank you very much. Will wait patiently, better late than never. 👍
@jspenguin2017, is Ublock 1.19
Any information about support on old Edge on EdgeHtml ? Will you add some update your extension?
Dear @jspenguin2017, as you're aware uBlock Origin 1.19.0 is out. How likely is an updated Nano release for EDGEHtml and if, what's the time frame, please? Have a nice weekend.
@jspenguin2017 thank you. And you need know something. Old version doesn't block cookies, downloaders and more on dobreprogramy.pl in EdgeHtml. Will be fix with new Nano Adblocker?
@seba2282 Probably not, that sounds like a filters issue. Make sure you have the regional filters enabled.
Hum... It looks like the new build is working alright on the legacy Edge. The Logger is not working but I don't see any major issues. I'll publish a new build.
@jspenguin2017 much appreciated. The logger neither works on the current version. any chance to have a go at it in the near future, please? Thank you.
@PeteAtGH If I can find a good polyfill for legacy Edge's broken querySelector then maybe... You can just use F12 DevTools, so I don't consider it a big issue.
@jspenguin2017, you didn't think over publicate nano Defender for Edge legacy? Mean in Microsoft Store? 🙂
@jspenguin2017 no worries, thank you for the tip. Many thanks again for all your efforts.
@seba2282 an updated Nano Adblocker has been published nearly 1 hour ago in the Microsoft Store.
I don't know why but it always take few to several hours until it's available for download/update.
@PeteAtGH, installed, Actual in my country is older version.
@jspenguin2017, you wondered about public Nano Defender?
@jspenguin2017, I understand all. But @PeteAtGH wrote about is update in Microsoft Store for nano adblocker. So qustion, when nano defender will be too in MS store?
@seba2282 I have answered your question here: #253 (comment)
I submitted an update, not sure if Microsoft is still accepting them though.
@jspenguin2017 Can send an update for the new edge?
@gdata1 No, I don't have access to that listing. You can just install from Chrome Web Store though.
@jspenguin2017 In the Microsoft Store the time stamp of the most recent update is showing 12/05/2019 02:43:46 at present.
@seba2282 I got an email asking me to update the screenshots, which are definitely really out of date by now. It shouldn't take too long, hopefully I can get it done today or tomorrow.
I just re-submitted the update.
@jspenguin2017 - MANY BIG THANKS. The long expected updated Nano Adblocker
0.0.109.0 is available to install from MS Store. You are a Gentleman.
@seba2282 - Enjoy !!!
@jspenguin2017, thank you. 👍
So now waiting on Nano Defender. Edge on Chromium will be probably near ending year or start 2020. So please look on my suggest positive and give ND finally to MS Store.
Thank you. 🙂
@seba2282 I already submitted Nano Defender to Microsoft Store last year, but it's still in queue. That's out of my control.
@jspenguin2017, ahh... So you don't know why Microsoft won't accept your defuser for adblocker and put to Store. If I good understood.
I see the problem, legacy Edge does not support :scope.
Looks like this can be easily fixed by a clever hack by jonathantneal. I'll ship a fix.
Nano still has problem with hidden Avast promo and dowbloader on dobreprogramy. But Adguard Team fixed problem with Rodo/cookies on filters. Maybe time fix that not blocking Avast promo and dowbloader after refresh site? Nano should hide that elements normal with filters. But something in code make doesn't hide that.
@seba2282 OK, I see the problem. I'm not sure why it's happening but neither the official Edge port nor Nano can hide those ads. It does work on Chrome though, which is kind of weird.
jspenguin2017 You're a HERO. Today's update fixed "The logger". Amazing. Thanks a lot.
@jspenguin2017, you fixed problems with cookies and hiding Avast promo with downloader on dobreprogramy.pl ? What I reported you for Edge on EdgeHtml?
@seba2282 I'm not sure what's causing the issue. I see some errors thrown from browser internal code. I still need to investigate.
@jspenguin2017, but you found what making that errors in browsers? Adguard needed one rule fix and only that Adblocker actually hasn't problem on MS Edge EdgeHtml. I don't know, how they make that, but seriously it work. About nano/ublock origin, I have problem with them on old Edge and I don't know, why. They won't block me on Edge cookies/rodo, ads and others. Is something bad. @gorhill hasn't any fix?
@seba2282 Nope, no clue what's causing the errors, the stack trace is empty. Looks like it's coming from native code.
@jspenguin2017, you should contact with someone from Adguard Team too for ask how fix problems. You all are developers. Adguard Team always like help and they are really good. Maybe try contact with them. 🙂
@seba2282 No, that doesn't make sense. The architecture of the two extensions are vastly different.
@jspenguin2017, maybe go merge Nano Adblocker with Nano Defender in one extension and bundle scripts and rules filters? Adguard will back script filters to Adguard 3.1 and again will be great skip between anti adblocks and all again will works great. Maybe try that way. 🙂
@seba2282 if I may say something, please don't get me wrong but none of the various adblockers I've ever used is perfect with every browser. Nano has been the best one for me so far in many different environments like work & private and Adguard is breaking far more sites than Nano, requires more resources and slows down browsers. After all, it's still a viable option in case Nano retires. There is another browser I use every now and then called Monument Browser, available from MS Store. It has got a build-in ad blocker and anti social and tracking filter, which you can enable in Extra Features. I tried the website you mentioned before "https://www.dobreprogramy.pl" and didn't see a single ad.
@seba2282 Nano Defender cannot be made configurable with current APIs, so I cannot merge the two extensions. The legacy Edge is on its way out, I rather not introduce big changes for it.
Problem is that, if look on Nano with UBO and Adguard. Adgurd blocks actually better on old Edge. After add rule for blocking cookies/rodo on domains wp.pl, ada still aren't blocking on dobreprogramy.pl example. If use Adguard (I reported that bug with cookies and they added very good rule for fix), he blocks all. More people say, Adguard team use better scripts and rules in Adguard and that works very good. To version 3.1 will come back scripts rules filters so will better like earlier. So @jspenguin2017, I gave you great suggest earlier, what is possible.
@PeteAtGH, that what Adguard break, it is by filters what you turned. There are filters what tagged as obsolete/problematic. You don't need turn them. About memory or browser slower, I don't know why is that. On Android Firefox I know AG use much memory, so actually use app Android. On PC I don't see to much slow browser. But... Team AG promised future optimization memory.
Add custom filter
dobreprogramy.pl##+js(nano-remove-elements-onready.js, #phContent_avastBadge)
and update Windows to 19H1, Avast promo gone.
Works after refresh site? If you visited dobreprogramy.pl, you had cookies to accept and downloader some program if you not logged? After refresh site, I know, didn't work nothing. But if 19H1 fix problem, then try that after moment. Thank you
@seba2282 If you think you have a great suggestion, feel free to test it out and send a PR. We can discuss and test it further.
@jspenguin2017 Many thanks for keeping Nano updated. Everything works fine apart from when attempting to open Nano settings in InPrivate mode "HTTP 501 error This website can’t or won’t display the page you want" - any idea? Tried on several PCs with the same outcome. Thanks.
@PeteAtGH Side effect of spanning mode. Split mode has bigger issues though. One workaround is to open a normal window instead of relying on runtime.openOptionsPage. I'm quite busy recently so a PR for Edgyfy is welcomed.
I suggest read that article (few without Edge Chromium topic) but about manifest api 3.0 for chromium:
https://www.theregister.co.uk/2019/05/29/google_webrequest_api/
There's a bug in version 116 that can be triggered by Adguard filters. A fix landed in version 117 which is in the certification queue.
If you are on default settings and your browser language is not Russian, then you're not affected.
@jspenguin2017 The filter lists stopped updating or being modified in version 0.0.123.0 for EdgeHtml on all devices I supervise. Please help.
Looks like the CDN hosting the filters is having some issues, I'll investigate.
I reproduced the issue with filters update, and it's not caused by the CDN server issues. I'm not sure why it's happening and I don't have time to debug it. Contribution welcomed.
I highly recommend everyone still using legacy Edge to upgrade to the new Edge as it's clear that I won't be able to provide support for legacy Edge for long.
@jspenguin2017 PLEASE , PLEASE try to fix the lists' updating issue for EdgeHTML. There is constantly something wrong with the new Edge, it's not usable, please have a look: https://techcommunity.microsoft.com/t5/Discussions/Updated-Dev-channel-update-to-78-0-268-1-is-live/m-p/847300 , many sites are not being rendered properly, keeps crashing daily.
The new Edge is just crap, same as Chrome/Chromium. Microsoft's worst decision ever.
I don't have time to debug this right now. If the previous version works, I'll do a rollback.
I'll test it this weekend if I have time.
PeteAtGH Я не согласен с тобой. Я пользуюсь новым преимуществом, и серьезных проблем нет. Я вижу много плюсов по сравнению со старым краем.
@jspenguin2017 Please don't roll back to any of the previous versions as the current one 0.0.124.0 doesn't throw up any errors in the Windows Problem Report. And there is something weird about the lists' update status displaying exclamation marks, because actually the lists are being effectivelly updated in the background. After a new one added, it won't update straight away but it will eventually happen rather sooner than later. Maybe 0.0.125.0 will fix the issue?