NVIDIA / libnvidia-container

NVIDIA container runtime library

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Building binaries, not just packages?

deitch opened this issue · comments

Is there a way to build the binaries (executables and libraries), not just the deb or rpm, etc. packages? I dug into the Dockerfiles for centos and ubuntu, and both do their builds internally on scratch space, collecting just the .deb files for external consumption.

Can we include the binaries themselves? It is good that Dockerfile.centos uses CentOS to do a build, and also that it provides centos-compatible rpm packages, but it should be possible to get the binary artifacts themselves, not just the installation packages.

As it is, these already have to be built, so why not make them available?

Just run make.

git clone https://github.com/NVIDIA/libnvidia-container.git --depth=1
cd libnvidia-container
sudo apt install golang bmake m4 libcap-dev
make  
cd deps/src/elftoolchain-0.7.1/libelf
cc -pipe -o libelf.so.1 -shared -Wl,--soname=libelf.so.1 -Wl,--whole-archive libelf_pic.a -Wl,--no-whole-archive
cd -
make
make install prefix=/usr/local

Or do you mean to just have a binary in the release directory? Problem with that is it will probably not run on a bunch of systems.

Actually, I rather like what you did (other than the apt install for dependencies, which assumes one is on apt-compatible system, but that can be abstracted away).

Can we add those to the instructions?