NVIDIA / VisRTX

NVIDIA OptiX based implementation of ANARI

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

VisGL with EGL MSVC build error

ColinChargyBentley opened this issue · comments

Hi,
On MSVC, near and far are reserved keywords (cython/cython#1959), so building VisGL with EGL throws these errors :
devices\gl\generated\VisGLObjects.h(289,33): error C2208: 'visgl::Parameter<1068>': no members defined using this type
devices\gl\generated\VisGLObjects.h(290,32): error C2208: 'visgl::Parameter<1068>': no members defined using this type
devices\gl\generated\VisGLObjects.h(319,33): error C2208: 'visgl::Parameter<1068>': no members defined using this type
devices\gl\generated\VisGLObjects.h(320,32): error C2208: 'visgl::Parameter<1068>': no members defined using this type

Can I rename near and far to nearDistance and farDistance ?

Regards,
Colin Chargy

@progschj what ideas do you have for this with the code generation that VisGL uses?

Thats annoying. That part of the code is generated. I‘ll have to add a list of keywords to dodge in the generator i guess.

It seems like they are actually defines that can be undefined without consequence. https://stackoverflow.com/questions/118774/is-there-a-clean-way-to-prevent-windows-h-from-creating-a-near-far-macro

I tried to address this issue in the next release branch 8af2eed