Multiple training file support
seanliu96 opened this issue · comments
Describe the bug
An exception is raised when trying to use model.data.train_ds.file_names
to provide multiple data files in SFT and DPO.
Steps/Code to reproduce bug
When setting the config model.data.train_ds.file_names
with multiple training files rather than using file_path
, an exception is raised because https://github.com/NVIDIA/NeMo-Aligner/blob/main/nemo_aligner/data/nlp/builders.py#L267 only consider file_path
and assume it is not None
.
Expected behavior
The build_sft_dataset
and other similar functions should detect whether cfg.file_names
is specified and then build datasets.
Sorry for the wrong label. It should be a feature.