[BUG] Compilation error with MATX_ENABLE_CUTLASS in transforms/matmul.h

Question

[BUG] Compilation error with MATX_ENABLE_CUTLASS in transforms/matmul.h

bk8190 opened this issue 4 months ago · comments

Describe the Bug
Compilation error in MatX/include/matx/transforms/matmul.h when building with MATX_EN_CUTLASS=on

Regression seems to have be introduced by d75d702
The commit replaces "idx" with "a_idx" "b_idx" and "c_idx". The variable "idx" likely needs to be updated in the #if MATX_ENABLE_CUTLASS block starting on line 948

Cliff Burdick · Answer 1 · Wed Apr 10 2024 22:14:59 GMT+0800 (China Standard Time)

Hi @bk8190 , we were not aware of anyone using the cutlass interface since it's untested. We will take a look and make sure it compiles. Can I ask why you're using this over the default cublas interface?

Bill Kulp · Answer 2 · Wed Apr 10 2024 23:15:03 GMT+0800 (China Standard Time)

Hi @cliffburdick - I am experimenting with the library and saw the option in the main CMakeLists.txt so I figured I would give it a try, but if it's untested I will stay clear

Cliff Burdick · Answer 3 · Wed Apr 10 2024 23:20:15 GMT+0800 (China Standard Time)

@bk8190 it was working several months back, but because of the compile times it was taking far too long to test. We had to put it on hold in favor of cuBLAS because of the compile times. CUTLASS does have a few more capabilities that cuBLAS did not have at the time, like non-affine indexing, but the compile times were ultimately not something we could deal with for now. If you have a reason to use it over cuBLAS please let us know.