Static string in CloudTraceConfiguration::project_id

Question

Static string in CloudTraceConfiguration::project_id

abdolence opened this issue 2 years ago · comments

Abdulla Abdurakhmanov commented 2 years ago

Hey, I was working with some previous builds of this library that used normal String type for project_id for Google traces and it was working fine. Now I tried to upgrade to 0.6 and I see it was changed to &static str.

Since commonly GCP project IDs are coming from configurations, environment variables, etc, this made now it more complicated to define.
What is the reason it is defined that way?
I would want to avoid using Box::leak and hacks just to specify project ids.

Alex Pearson · Answer 1 · Sat Nov 19 2022 07:27:51 GMT+0800 (China Standard Time)

That's a fair point. For my own uses, project_id and similar Google-level configuration was static, but of course it makes sense that an Env-based String configuration would be useful, too. That seems worth a patch, stand by.

Alex Pearson · Answer 2 · Sat Nov 19 2022 07:44:27 GMT+0800 (China Standard Time)

@abdolence just published v0.6.1 with project_id configured with an owned String. Thanks for opening this issue!

Abdulla Abdurakhmanov · Answer 3 · Sat Nov 19 2022 17:31:40 GMT+0800 (China Standard Time)

Thanks for the quick fix!