[Improve Existing Best Practice Guide]: CI Architectural Reference Guide Diagram Clipping Issues
riverma opened this issue · comments
Checked for duplicates
Yes - I've already checked
Best Practice Guide
Continuous Integration
Best Practice Guide Sections
Reference Architectures
Describe the improvement
The Mermaid diagrams have clipped text that doesn't ready fully. This is present in both GitHub view as well as the rendered RETYPE webpage view. Attached is an example. Additionally the "A series of systems executing builds" diagram is not rendering the bold-typed text properly (picture attached).
What browser are the screenshots from so that I can reproduce this?
Also, I see that in the retype view the bold text is an issue whereas in the GH view it looks proper. I think I need to look into a retype conflict.
Changes were made in the develop branch and the issue_23 branch pre-merge to reflow the RA README. We should check with the issue_23 PR to see if this helps it.
@jpl-jengelke - this bug was witnessed in the following environment: Safari 15.5
If you've come up with a potential fix, you may want to try and fork the repository at the branch you've put the fix for (develop?) and try rendering the site in your fork - that way you can test your fix with an independent site URL.
I believe I have this resolved pending PR release.
@jpl-jengelke - still see the clipping issues in the develop branch. Did you push the fix to another?
@jpl-jengelke - clipping issues remain on deployed branch. See example: https://nasa-ammos.github.io/slim/continuous-integration/reference-architectures/
We've got about 12 people who indicated interest in using this guide. Let's fix these so that we can help them infuse! :) Once fixed, we can work on #77