NARKOZ / gitlab

Ruby wrapper and CLI for the GitLab REST API

Home Page:https://narkoz.github.io/gitlab

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

dependency on httparty to be bumped to >= 0.18 because of tests?

boutil opened this issue · comments

Hi,

The following change
46343c91940df46d773e564
is not needed for httparty 0.17.3, and results in test failures with httparty 0.17.3 and earlier. However, it is needed for tests to pass with httparty 0.18.

Maybe it is better to indicate that the minimal version for httparty is 0.18 and not 0.14?

Thanks

P.S.: this is related to a Debian bug where httparty 0.18 is causing test regression with gitlab 4.14.1.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=974093

Thank you. Fixed in 87ff403 and version 4.17.0 was released which includes this fix.