N4S4 / synology-api

A Python wrapper around Synology API

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

date_expired not used in create_sharing_link or edit_sharing_link

danieleTrimarchi opened this issue · comments

In filestation.py : the argument date_expired is mentioned in the function signature but it is not used (and the same for date_available) :

def create_sharing_link(self, path=None, password=None, date_expired=None, date_available=None): 
    ...

def edit_shared_link(self, link_id=None, password=None, date_expired=None,   date_available=None):
    ...

Would it be possible to allow for using this parameter ?

Ciao Daniele,

yes I remember while I was writing the functions I faced some issues so it was on the TODO list, I'll try to look again in the docs and try again to work on it, if you have hint or start to work on it just let me know

Hi N4S4,

Is this function fixed XD? I found the same bug~~

Hi @dppss90008

You are right i did not look into it, I will see whats going on in this days

Hi N4S4,
same function but I wanna a sharing_downloaded_counts limit. I saw File Station can limit the count of downloading like url will be expired after downloading >3 times.
But the function does not contain this param.
Have a nice day~

A bit of delay on this,

from the image below should be easy to make use of date_expired and date_available

image

even though should work with the original code, I modified and tested but i cannot make it work, not sure at this point if is about the code or the api it self.

Will make sure is nothing from the code

Hi N4S4, same function but I wanna a sharing_downloaded_counts limit. I saw File Station can limit the count of downloading like url will be expired after downloading >3 times. But the function does not contain this param. Have a nice day~

expire_times limit is been added and tested, next release will be available, added with PR #109