MyIntervals / emogrifier

Converts CSS styles into inline style attributes in your HTML code.

Home Page:https://www.myintervals.com/emogrifier.php

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Support @charset in the CSS

visioncan opened this issue · comments

commented

My css file with @charset "UTF-8" like:

@charset "UTF-8";
body {...} 

will output wraning:

Warning: DOMXPath::query(): Invalid expression in /Users/../vendor/pelago/emogrifier/Classes/Emogrifier.php on line 353

https://developer.mozilla.org/en/docs/Web/CSS/@charset

Currently, Emogrifier does not support charset in the CSS yet. If you are using only ASCII characters in your CSS, you can safely remove the charset.

We added support for dropping @charset rules without impacting CSS parsing in 2.0.

I don't think we'll ever support alternative charsets to UTF-8, which is the norm these days, unless that norm miraculously changes.

Can we close this as either 'fixed' or 'wontfix'?

Yes, let's close this.