Mark the public class constants as `@internal`
oliverklee opened this issue · comments
Those class constants are not intended to be accessed from outside this package.
Do they need to be public
at all?
Do they need to be
public
at all?
Some of them, yes, as they are either part of an interface (where only public const
s are possible), or because they are accessed from another class.
Do they need to be
public
at all?
Setting the visibility of class constants (e.g. with private const
) has only been possible since PHP 7.1. So it's only now possible to clear this up since dropping the older PHP versions.