MyEtherWallet / ethereum-lists

A repository for maintaining lists of things like malicious URLs, fake token addresses, and so forth. We love lists.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Future after MyCrypto/MEW split

ligi opened this issue · comments

commented

will this project continue here?

I was hoping so as many people are relying upon it and there are links everywhere. However, kvhnuke has revoked my write access so I am no longer about to merge pull requests. Would you like to start a new repo and start it with the new single-file-per-token as discussed?

commented

This is really sad to hear and I really hope the wounds between you and kvhunke will heal at some point. Think I will do the repo then ..
Do you have objections to it being a repo in the WallETH organisation? Or would you prefer it to be a separate organisation?

commented

I have write access to this repo still if that helps make a decider

commented

@409H that's great - but I would love to avoid a bus-factor of 1 ;-)
Thinking about this a bit longer I think I am opening a new organisation for this to keep it neutral and learn from history ..

I'll do whatever makes the most sense for the largest amount of people. The intentions of this repo was always far more global than what it is right now so I'm open to recommendations or others to take to lead and tell me how I can help

commented

Thinking about this a bit longer I think I am opening a new organisation for this to keep it neutral and learn from history ..

When you do, please can you link me?

commented

When you do, please can you link me?

@409H already invited you to the organisation (https://github.com/ethereum-lists) - didn't you get the invitation? @tayvano already joined as far as I see

commented

@ligi thanks! I didn't see the invite come through, but I've just accepted

commented

@ligi thanks! I didn't see the invite come through, but I've just accepted

You are very welcome! The good thing about the whole situation I can now set up a ci-server to automate some work as I had in mind but not the permission (context: #347 #37 #227 #28)

commented

the ethereum-lists org is officially open: http://walleth.org/2018/02/15/ethereum-lists
Also did the split/merging suggested in #347

Hey everyone, @SteveMieskoski from MEW team will be maintaining this list. He is also working on a nodejs app to merge all different lists into one. So Im totally cool with you guys using a seperate repo as well since we will merge it here at the end!

commented

@kvhnuke great! You can also use the script I have done for merging - it is MIT licensed.

@ligi that's awesome, one less thing to do. Can you post the link?

commented

@kvhnuke Sure thing: https://github.com/ethereum-lists/tokens/blob/master/src/main/kotlin/org/ethereum/lists/tokens/Main.kt

This one assembles 2 json files for each network: one full one with all fields and a minified one with only address, name, symbol and decimals

It is also doing it that way that the CI-Server picks it up and uploads the stuff per commit to IPFS - looks like this then:
https://gateway.ipfs.io/ipfs/QmPQDKrGDGBW3gnyu8iGUsV42bckU22tx4M1415iVhkWCZ

commented

@kvhnuke what do you think about adding a "version" field to the token-json. I am thinking about merging strategies - we should really avoid that things diverge. It is easy to merge new tokens - it is a bit more problematic for updates like ethereum-lists/tokens#4

@soc1c what are you confused about?

which repository to use.

commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed within 10 days if no further activity occurs. Thank you for your contributions.

commented

Closing because of inactivity