MurhafSousli / ngx-highlightjs

Angular syntax highlighting module

Home Page:https://ngx-highlight.netlify.app/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Warning: Entry point 'ngx-highlightjs' contains deep imports into /node_modules/highlight.js/lib/highlight'

muuvmuuv opened this issue · comments

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] question

OS and Version?

macOS 10.15.5 (19F101)

Versions

Angular CLI: 10.0.0
Node: 12.18.0
OS: darwin x64

Angular: 10.0.1
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router, service-worker
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.901.9
@angular-devkit/build-angular     0.1000.0
@angular-devkit/build-optimizer   0.901.9
@angular-devkit/build-webpack     0.901.9
@angular-devkit/core              9.1.9
@angular-devkit/schematics        10.0.0
@angular/cdk                      10.0.0
@angular/cli                      10.0.0
@ngtools/webpack                  9.1.9
@schematics/angular               10.0.0
@schematics/update                0.1000.0
rxjs                              6.5.5
typescript                        3.9.5
webpack                           4.42.0

Repro steps

  1. Use NG10

The log given by the failure

Warning: Entry point 'ngx-highlightjs' contains deep imports into '//node_modules/highlight.js/lib/highlight'. This is probably not a problem, but may cause the compilation of entry points to be out of order.

Desired functionality

No warning. As noted here I am opening the issue to inform you that this happens.

Mention any other details that might be useful

I read somewhere that those errors should disappear when compiling witht NGCC version 10.

Building the app also produces:

WARNING in /Users/marvinheilemann/Development/Additive/Kunden/Fraunhofer/AQUA-Filter/node_modules/ngx-highlightjs/__ivy_ngcc__/fesm2015/ngx-highlightjs.js depends on highlight.js. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in /Users/marvinheilemann/Development/Additive/Kunden/Fraunhofer/AQUA-Filter/node_modules/ngx-highlightjs/__ivy_ngcc__/fesm2015/ngx-highlightjs.js depends on highlight.js/lib/highlight. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Okay I am wrong about that, this is needed. I forgot that ngx-highlightjs is build upon highlight.js. I wonder if it is possible to tell that the compiler without requiring project authors to include allowedCommonJsDependencies.