ModelInference / texada

Efficient techniques for mining LTL formulae over linear input traces

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Make Texada code more readable

bestchai opened this issue · comments

Following the code review, Ivan suggested many small refactorings in the code/renamings that would make the texada project more accessible/readable.

Biggest changes so far:

incorporating temp map prop type miner into property type miner

renaming array_trace_checker to linear_trace_checker

renaming formula_instantiator to ap_subbing_cloner. (Atomic proposition substituting cloner, which is what it does on the data structure level -- public method is still called instantiate to be consistent with language used in proposal)

[Issue created by carolemieux: 2014-07-10]
[Last updated on bitbucket: 2014-08-08]

[Comment created by carolemieux: 2014-08-08]
This is just a very unclear issue. I should get into the habit of adding comments while I code more, going over after is more difficult.

[Comment created by carolemieux: 2014-07-28]
added comments to map trace checker 1312bc992246

[Comment created by carolemieux: 2014-07-18]
map_trace_checker needs a lot more comments/clarity!

[Comment created by carolemieux: 2014-07-14]
Finished first round of improvement, resolving for now.

[Comment created by carolemieux: 2014-07-11]
Created subdirectories, have documented most things with comments. Still missing some class/header-file level descriptive comments

[Comment created by carolemieux: 2014-07-11]
I've advanced on this (hopefully) quite a bit. Along the way I modified a few functionality things -- i.e. I made some big data structures get passed along by pointer instead of by reference.

Have not organized things by folder.