MmgTools / mmg

open source software for bidimensional and tridimensional remeshing

Home Page:http://www.mmgtools.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

CMake cleaning

Algiane opened this issue · comments

  • Remove old (and useless) things:
    • Dart related config;
    • useless compiler flags / options;
  • Make configuration more friendly with cmake-gui :
    • Do not let USE_ variables as checked if is not found;
    • [ ] Try to limit the number of configuration steps (Dependent options);
  • Actions hierarchisation / re-ordering:
    • Move dependencies research in a dedicated file;
    • Move archive creation in a dedicated file;
    • Try to have one CMakeLists.txt that call other CMakeLists.txt
  • Allow disabling of Doxygen;
  • List only needed libraries of VTK;
  • Specific very fast tests for valgrind;
  • #147

Commits 3b1736a, 11d099b, and 6e9642 changes the behaviour of the USE_SCOTCH CMake cache variable:
- if user don't provide directive, Scotch package is searched in quiet mode.
- if user set USE_SCOTCH to OFF, Scotch is not searched
- if user set USE_SCOTCH to ON, Scotch is searched in verbose mode. An error is raised if scotch is not found.
- if user set USE_SCOTCH to a string not evaluated to 'false' or 'true' following the cmake convention (doc), USE_SCOTCH is finally considered as true.

⚠️ With previous behaviour, except in the case where the user was setting explicitely USE_SCOTCH to OFF:

  • only a warning was printed when scotch wasn't found;
  • scotch was always searched at each new configuration (which is not the case anymore);

⚠️ : commit 573ce modifies the behaviour of the USE_ELAS and USE_VTK variables following the same convention.

For now CMake's hierarchization is abandonned.
Fast valgrind tests have been added but only to sonarQube instance of Mmg.