Giters

MithrilJS / mithril.js

A JavaScript Framework for Building Brilliant Applications

Home Page:https://mithril.js.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Wrong archive links when already in archive

tbreuss opened this issue · comments

commented

When we are viewing an archived version and we try to change to another version, this results in a 404 page not found error. This is quite annoying.

See screenshots.

  1. Here we are in a archived version:

  1. And this is the 404

The solution to the problem consists of two parts:

  1. Edit the generator-docs.js script

Simply add a slash at line https://github.com/MithrilJS/mithril.js/blob/next/scripts/generate-docs.js#L98. I have a commit in a docs-update branch.

  1. Edit generated gh-pages

For already archived docs we have to edit content at https://github.com/MithrilJS/mithril.js/tree/gh-pages/archive, if we wan't to fix this.

commented

Fixed with

  • #2835: fixes the problem for the generated gh-pages (the current and archived versions)
  • #2839: fixes the problem for future versions