MishaKav / pytest-coverage-comment

Hi, @MishaKav, thanks for your fantastic action!

I am trying to enable the badge update workflow and it did not work for me, so I tested each steps separately and got to here:

pytest-coverage-comment/README.md

Line 153 in 0e5d939

echo "Coverage Html - ${{ steps.coverageComment.outputs.coverageHtml }}"

Coverage Percentage - 82%
Coverage Color - green
Coverage Html - ""
/home/runner/_work/_temp/58ddf838-2bbf-44c9-b520-6d9de2814490.sh: line 4: syntax error near unexpected token `<'

My understanding is that the HTML result contains escape characters that the script doesn't know how to ignore.
It seems like the jest version you made have some improvements in that part of the code, is it possible to try and align their code base somehow maybe?

I also saw here another issue:

pytest-coverage-comment/.github/workflows/update-coverage-on-readme.yml

Line 32 in 0e5d939

    
                     sed -i '/<!-- Pytest Coverage Comment:Begin -->/,/<!-- Pytest Coverage Comment:End -->/c\<!-- Pytest Coverage Comment:Begin -->\n\${{ steps.summary_report.outputs.content }}\n<!-- Pytest Coverage Comment:End -->' ./README.md

summary_report is not a valid id

Hoping to hear back from you soon :)

Hey,

Try to run your example without printing echo "Coverage Html..." (just remove this line)
You are right, instead of summary_report, it should be coverageComment (I've already update the main branch with that)

thanks for the swift response!
I actually need the Coverage Html because I wanted to use the example here:

pytest-coverage-comment/README.md

Line 267 in ed05a2e

    
                     sed -i '/<!-- Pytest Coverage Comment:Begin -->/,/<!-- Pytest Coverage Comment:End -->/c\<!-- Pytest Coverage Comment:Begin -->\n\${{ steps.coverageComment.outputs.coverageHtml }}\n<!-- Pytest Coverage Comment:End -->' ./README.md

you can still use the HTML response in this line

pytest-coverage-comment/.github/workflows/update-coverage-on-readme.yml

Line 32 in ed05a2e

    
                     sed -i '/<!-- Pytest Coverage Comment:Begin -->/,/<!-- Pytest Coverage Comment:End -->/c\<!-- Pytest Coverage Comment:Begin -->\n\${{ steps.coverageComment.outputs.content }}\n<!-- Pytest Coverage Comment:End -->' ./README.md

Try to remove the "echo" line with "HTML"

pytest-coverage-comment/README.md

Line 153 in 0e5d939

echo "Coverage Html - ${{ steps.coverageComment.outputs.coverageHtml }}"

I'll try this, btw the first link you sent also use the wrong id

outputs.content is not valid, did you mean outputs.coverageHtml? I get an empty result from outputs.content

Yes, I mean, just remove this line

echo "Coverage Html - ${{ steps.coverageComment.outputs.coverageHtml }}"

I tried many things, in the end the only thing that worked was using ${{ steps.coverageComment.outputs.summaryReport }}
it adds "" that I don't need, but the content is here at least

Thanks for sharing

Escape character seems to be failing the basic example