Giters

Mirantis / cri-dockerd

dockerd as a compliant Container Runtime Interface for Kubernetes

Home Page:https://mirantis.github.io/cri-dockerd/

Repository from Github https://github.comMirantis/cri-dockerdRepository from Github https://github.comMirantis/cri-dockerd

Consolidate Makefiles

nwneisen opened this issue · comments

commented

Expected Behavior

A Makefile exists in the root of the project that imports Makefile values and targets from other mk files.

We should try to move the project towards being organized using the standard go project layout. This would have us moving our imported mk files to the build/ directory along with the packaging directory.

Suggested project reorganization:

build/
  packaging/*
  common.mk -> Move high level Makefile vars here
  packaging.mk -> Current packaging/Makefile
packaging/
Makefile -> Import the build/*.mk files

Since we are currently placing our build artifacts in the build directory, we should instead output them to the bin directory as is common practice with many projects. We should also eliminate any duplicate build artifacts.

Actual Behavior

We currently have Makefiles in multiple locations throughout the project with duplicated targets and variables. This is not the end of the world but it there are now multiple different ways to build different artifacts for the project.