Allow more cache settings for the nginx proxy cache
pscheit opened this issue · comments
Hey there, thanks so much for this docker image, works pretty good so far and is ok to understand.
I experimented a little bit an in production I want to add
proxy_cache_min_uses 0;
after this line.
thumbor/nginx-proxy-cache/nginx.tmpl
Line 22 in 4c9f8f4
Can we somehow make the cache more configurable?
a) (would work for me) add just this proxy_cache_min_uses setting with a var
b) can we even include a whole config block here? (maybe more stuff I need to change)
I'd rather not copy the whole nginx.tmpl to just change 1 line :/
What you think? Would PR it then
Hey @pscheit 👋
The template is based on https://github.com/nginx-proxy/nginx-proxy and unfortunately I had to monkey-patch it, because it wasn't as flexible for this use case. So maintaining the template is a bit of a challenge in general (e.g. getting upstream changes from https://github.com/nginx-proxy/nginx-proxy back to this project is a manual process).
If you want to make this portion more configurable, then I would suggest going upstream to https://github.com/nginx-proxy/nginx-proxy and creating a PR there. Assuming that's accepted and merged-in, we can then do a one-off re-import process to update our own template...
Applying even more changes to our own template isn't something I'd be too keen on, because it increases the complexity of re-importing as I mentioned.
Of course, you can always use your own template. I understand it's not ideal for a one-line change, but I'm not sure how to balance things without creating burden on this (and to some extent the upstream nginx-proxy) projects.
Does it make sense? happy to help if I can making things better. loosely related: #39
Makes total sense. I'll try to prioritize it for next Week!
Glad to hear, @pscheit. Let me know if there's anything I can help with.
Closing due to lack of activity. If you are still interested working on it and contributing to the project, please let me know and I’d be happy to help :)