creating more tests

Question

creating more tests

gingerlime opened this issue 5 years ago · comments

I recently created some simple tests to cover nginx-proxy caching (#47) using bats-core, and integrated them into the automated build/test/push process on Semaphore 2.0.

Probably makes sense to write a few more tests to cover common scenarios, but not sure exactly what should be tested (it doesn't make sense to duplicate tests that thumbor core is doing, so focus only on the docker images)

gingerlime · Answer 1 · Sat Aug 03 2019 17:27:33 GMT+0800 (China Standard Time)

@kkopachev can you suggest some things we could/should test and how to test them?

Konstantin Kopachev · Answer 2 · Sat Aug 24 2019 06:40:18 GMT+0800 (China Standard Time)

🤷‍♂️
Not sure if there are anything which deserves testing.
nginx-proxy should just be replaced with nginx caching.

gingerlime · Answer 3 · Sat Aug 24 2019 12:51:09 GMT+0800 (China Standard Time)

Thanks @kkopachev. Yes, you're probably right. I think I realized while writing tests that they are mostly related to nginx proxy caching. If we replace it with nginx built-in caching there's much less to test. Still probably a few things like AUTO_WEBP and correct headers might be worth testing, but it's still either testing nginx or thumbor, both projects have their own tests :)

I'll close this for now!