MiniProfiler / rack-mini-profiler

Profiler for your development and production Ruby rack apps.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Don't touch HTTP headers where possible

nate-at-gusto opened this issue · comments

Even if disable_caching is on, we still overwrite the applications HTTP cache headers.

This can make HTTP caching difficult to observe in development mode. I understand why we have hacks and workarounds here, but it would be better if we could avoid touching this stuff and let the app do it's thing.

Hello @nate-at-gusto , we are modifying the HTTP header to prevent browser from storing cache only if disable_caching is on. So, I don't find any problems with adding no-store to HTTP header if disable caching is on and feel like its the right thing to do.

If you still find that we need to prevent modifying HTTP headers, then can you please explain me the problem we will be facing here if we just let it be?