ASP.NET Core support
Daniel15 opened this issue · comments
Does MiniProfiler support ASP.NET 5? How difficult would it be to add support?
Is there something with MP that is not working on an ASP.net project?
I haven't tried it yet, but I don't think anything in StackExchange.Profiling.Mvc would work (as it references ASP.NET MVC 4 and the System.Web.Mvc namespace), and StackExchange.Profiling references System.Web which is no longer used with ASP.NET 5.
I verified that MiniProfiler 3.2.0.157 is, unfortunately, not compatible with DNX Core 5.0 - one of the platforms used by ASP.NET 5.
To make it compatible, I'm guessing a non-trivial amount of change will need to happen, mostly in the way of removing references to some of the assemblies like System.Web and System.Data.
MiniProfiler is one of a series of project at Stack Overflow that are slated for upgrades to support .Net 5. Probably wont be for another month or two though.
I implemented a miniprofiler core functionality for ASP.NET 5, and I would say it can be possible to integrate my solution with existing code base of original MiniProfiler project.
My project is here. It reuses some of concepts implemented in original MiniProfiler, but some things are made differently to allow multi-threaded profiling (I'm not sure if it is really needed, but I remember there was an issue about multi-threaded profiling).
Is ASP.NET 5 support ever going to happen? MiniProfiler is extremely useful, I would hate to see it fade away.
@rlenders Yes, it will happen. it is on a short list of Stack Overflow projects that are due for an upgrade to ASP.NET 5. However, this is only going to happen once .NET Core RC2 is released (since lots of things will be changing there, we're waiting for that release to work on things like this). Hang in there, we haven't forgotten.
@yellis RC2 is now released, which I'm sure you've already noticed. 😄
Once support has been added can you please send a PR so I can update the package support list at ANCLAFS.com.
I'm looking forward to being able to using MiniProfiler on ASP.NET Core websites as well. Thanks! :)
Do you have any ETA on this?
+1 for adding support.
That would be extremely useful!
@yellis Is there even a rough ETA for this? It's important for us to know whether we are talking weeks or months not to day years. Even a rough estimation will do.
p.s. Yad Binyamin rulezzz 😄
I realize that many of you have been waiting for this for some time. And that there have been multiple dates written earlier in this thread that have already come and gone. We appreciate your patience. You have not been forgotten.
We are of course, always busy with lots of things, but that in itself is not a reason for the delay here. There are some features that we are waiting for as a prereq for work on this (and other projects) that wont be around until .NET Core 1.2. Though 1.2 isn't slotted for release until Q1-Q2 2017, we hope to start work on the upgrade here as the .NET Core 1.2 beta bits are available. Which could be in a couple of months, but no way to know for sure.
I will update here when I have something significant to say about our progress.
@yellis
Thanks for the answer Yaakov.
Curious to know what are the missing features.
Closing this in favor of #144 (MiniProfiler V4) tracking - which include ASP.NET Core. The V4 branch is available here if you want to play early.