MikeOrtiz / TouchImageView

Adds touch functionality to Android ImageView.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Scroll position does not match the arguments that I am sending to setZoom

MaryChek opened this issue · comments

Good afternoon, maybe I don't understand something.
The situation is this: We have a picture, when opening the application, a certain place with a certain zoom must be approached. I know the coordinate of the center of the object that should be approximated when opening and in the center of the screen.
With version 3.0.3, everything works as it should and scrollPosition (x, y) are the same as what I passed to setZoom, but in 3.0.5 there is a slight shift in the view (a little down and to the right)

I guess it was #329 from @SimFG
Maybe he can clarify your question.

If you think you found an error or you can improve it, then I'm happy to approve your pull request

yes, I saw this proposal, so I decided to check the version before the edits were made, and it turned out that it worked the way I thought it should be. What do you suggest to me to do? Discuss my problem with @SimFG?

commented

Hello,

Just to let you know that I actually have the same regression than @MaryChek,

And if i rollback the PR #329, it works like a charm.

Hmm, currently I've no smart idea how to make both uses cases work.
But to use an old version also not the way to go. I'm open minded for any nice solution

commented

This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you!

commented

Closing this. Please reopen if you believe it should be addressed. Thank you for your contribution.