Disk harmonic plan segfaults when `n=1`

[Sheehan Olver]

I think I narrowed down the bug:

julia> using MultivariateOrthogonalPolynomials

julia> for _=1:10000
                  MultivariateOrthogonalPolynomials.CDisk2CxfPlan(2)
              end

julia> for _=1:10000
                  MultivariateOrthogonalPolynomials.CDisk2CxfPlan(3)
              end

julia> for _=1:10000
                  MultivariateOrthogonalPolynomials.CDisk2CxfPlan(3)
              end

julia> for _=1:10000
                  MultivariateOrthogonalPolynomials.CDisk2CxfPlan(3)
              end

julia> for _=1:10000
                  MultivariateOrthogonalPolynomials.CDisk2CxfPlan(3)
              end

julia> for _=1:10000
                  MultivariateOrthogonalPolynomials.CDisk2CxfPlan(4)
              end

julia> for _=1:10000
                  MultivariateOrthogonalPolynomials.CDisk2CxfPlan(4)
              end

julia> for _=1:10000
                  MultivariateOrthogonalPolynomials.CDisk2CxfPlan(4)
              end

julia> for _=1:10000
                  MultivariateOrthogonalPolynomials.CDisk2CxfPlan(4)
              end

julia> for _=1:10000
                  MultivariateOrthogonalPolynomials.CDisk2CxfPlan(5)
              end

julia> for _=1:10000
                  MultivariateOrthogonalPolynomials.CDisk2CxfPlan(5)
              end

julia> for _=1:10000
                  MultivariateOrthogonalPolynomials.CDisk2CxfPlan(5)
              end

julia> for _=1:10000
                  MultivariateOrthogonalPolynomials.CDisk2CxfPlan(1)
              end

julia> for _=1:10000
                  MultivariateOrthogonalPolynomials.CDisk2CxfPlan(1)
              end

julia> for _=1:10000
                  MultivariateOrthogonalPolynomials.CDisk2CxfPlan(1)
              end

signal (11): Segmentation fault: 11
in expression starting at no file:0
_ZN4llvm20AAResultsWrapperPass13runOnFunctionERNS_8FunctionE at /Users/solver/Projects/julia-1.1/usr/lib/libLLVM.dylib (unknown line)
_ZN4llvm13FPPassManager13runOnFunctionERNS_8FunctionE at /Users/solver/Projects/julia-1.1/usr/lib/libLLVM.dylib (unknown line)
_ZN4llvm13FPPassManager11runOnModuleERNS_6ModuleE at /Users/solver/Projects/julia-1.1/usr/lib/libLLVM.dylib (unknown line)
_ZN4llvm6legacy15PassManagerImpl3runERNS_6ModuleE at /Users/solver/Projects/julia-1.1/usr/lib/libLLVM.dylib (unknown line)

[Mikael Slevinsky]

Do you see the BLAS error when you call MultivariateOrthogonalPolynomials.CDisk2CxfPlan(0)? This may help determine if the segfault is coming from Julia or C.

[Sheehan Olver]

Can confirm it's fixed 🎉