[textDocument/rename] client doesn't obey `RenameOptions` while registering provider

[Talv]

prepareRename handler can't be registered because options.prepareProvider is never being set, even if server does include it in its capabilities.

Fix:

--- a/client/src/client.ts
+++ b/client/src/client.ts
@@ -2002,7 +2002,7 @@ class RenameFeature extends TextDocumentFeature<RenameRegistrationOptions> {
                }
                this.register(this.messages, {
                        id: UUID.generateUuid(),
-                       registerOptions: Object.assign({}, { documentSelector: documentSelector })
+                       registerOptions: Object.assign({}, { documentSelector: documentSelector }, capabilities.renameProvider)
                });
        }

https://github.com/Microsoft/vscode-languageserver-node/blob/d168533600cafd64023cade9f2b5e6dee74134d4/client/src/client.ts#L2005

[Dirk Bäumer]

@Talv very good catch. And sorry for the late response.

[Dirk Bäumer]

@rcjsuen FYI.

[Remy Suen]

Good to know for future contributions.

Thanks for catching this, @Talv!