New releases no longer work with `install.sh`

Question

lamafab opened this issue 3 years ago · comments

Hi

Your README instructs people to install the binary with the following command:

curl -LSfs https://japaric.github.io/trust/install.sh | \
    sh -s -- --git Michael-F-Bryan/mdbook-linkcheck

However, you recently changed the release packaging from tar.gz to zip. The install.sh script will attempt to download from the following URL:

https://github.com/Michael-F-Bryan/mdbook-linkcheck/releases/download/v0.7.4/mdbook-linkcheck-v0.7.4-x86_64-unknown-linux-gnu.tar.gz

While instead it should be (note the .zip):

https://github.com/Michael-F-Bryan/mdbook-linkcheck/releases/download/v0.7.4/mdbook-linkcheck.v0.7.4.x86_64-unknown-linux-gnu.zip

This is because how the install.sh script specifies the link:

url="$url/download/$tag/$crate-$tag-$target.tar.gz"

td=$(mktemp -d || mktemp -d -t tmp)
curl -sL $url | tar -C $td -xz