Code comments in shadow mask code
asturur opened this issue · comments
I was looking at the shadow mask code and explanative comments.
cdcb29f#diff-31aef25ffcf4833fc2d16e5f3d8f327e12febf4e6fb25e731cdf16cd16d5968aR99
I don't know verilog, i can barely understand what is going on.
It seems to me that comments are outdated.
It seems to me that the LUT has 64 slots and that the mask can be effectively 8 by 8.
Both the reference to max height and the top right corner being used to store the width and height max index seems incorrect or old.
i don't think it's a real issue.
it was at the time of writing it.
Then the code for the shadowmask changed.
In the new code there are no more comments, that is worse.
Is the shadowmask functionality documented somewhere?
shadow masks txt files are self-descriptive. Some of them have comment section in beginning.