New package for inclusion - aldeed:simple-schema
jankapunkt opened this issue · comments
Package/project name & description
aldeed:simple schema is the unmaintained Meteor version of simpl-schema which is required for Collection2 and aldeed:autoform among others
Links
Current status of the project
- Abandoned (the Meteor package at least, while the npm package is actively maintained)
Reasoning
The Problem is that the npm package dropped all Meteor support with new major version 3! This already caused issues with AutoForm and we should keep focussing to include this package.
The idea is to publish the same versions of the NPM versions as Meteor package but also Include all the dropped Meteor functionality
Progress
- Contacted, Meteor-Community-Packages/meteor-simple-schema#737
- Discussion finished
- Moved / Forked
- Team Created
- Meteor Org Created and set as maintainer
-
communitypackagesorg added as a maintainer on Atmosphere - Added to the community website project listings
When I migrated to simpl-schema 3, userId: { type: String, regEx: SimpleSchema.RegEx.Id }, is the only thing that bothered me. "SimpleSchema.RegEx.Id" is no longer supported. But ... from the documentation:
"
In earlier releases, the SimpleSchema.RegEx object defined standard regular expressions that you could use as the value for the regEx key. However, many of these were prone to DDoS security risks, causing this package to be flagged by security audit tooling. We no longer include any built-in regular expressions. We encourage you to use a custom function or some other method of validating any strings with complex requirements. If necessary, you can look back at the code for previous SimpleSchema releases and copy specific built-in regular expressions into your codebase.
"
I guess the missing bits in Meteor can be written as functions so that the Meteor packages can then depend on the latests versions of simpl-schema.
is there any problem if we use this package without using SimpleSchema.RegEx?
AutoForm and Collection2 max rely on the regex and Implementations of users may, too. We could easily provide the RegEx as before by simply adding it to the export or by providing an extra package but the tracker integration is not that trivial
The tracker integration is especially necessary if you have reactive translations for your schema validation. Also the message box is removed so if your implementation did heavily rely on simple schema then there is a lot more to refactor than just regexes.
Yes let's try to get simple-schema package and if we can't we'll fork.
I would like to volunteer on this one
Hey all, getting caught up. I'm okay with transferring the meteor package but it also may make sense to just add support for reactivity and other things directly in the packages that need it (e.g. autoform). Depends on how many layers of packages you want to keep track of.
I think it is preferable to transfer and for us to make it backward compatible as there are many more packages that expect that behavior and some of them won't be receiving any updates.
Transferred repo and added Atmosphere maintainer.
@aldeed Thank you!