Meteor-Community-Packages / meteor-collection-hooks

Meteor Collection Hooks

Home Page:https://atmospherejs.com/matb33/collection-hooks

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Collection.before.findOne does NOT modify selector when a string is used

KoenLav opened this issue · comments

When we use collection.:

  • findOne;
  • find;
  • update;
    with a string selector, rather than an object, the before hook will not update the selector properly in Meteor 1.6.1 on the server (have not verified on the client side).

Example:

someCollection.before.findOne(function(userId, selector) {
  selector = selector || {};

  if (typeof selector === 'string') {
    selector = {
      _id: selector,
    };
  }

  selector.someKey = 'someValue';
});

When we use findOne with a string selector the combination of someKey and someValue is ignored, when we use it with an object selector it is applied!