rewrite whole selector

[tillk9]

Isn't possible to rewrite the whole selector in .before.find ?

api.before.find(function (userId, selector) {
  selector =
  {
    $or:[
      {
        ... selector,
        userGroupId : "USER_GROUP_ID",
      },
      {public:true}
    ]
  }
  console.log("before",selector);
})

api.after.find(function(userId, selector, options, cursor){
  console.log("after",selector);
})

logs:

I was expecting that the first and the second console.log() would display the same.

[kmbriedis]

A little late to respond but...

JavaScript parameters don't work that way, you cannot reassign them. See this https://stackoverflow.com/a/16880456

To accomplish the desired result, you can use an ugly workaround like this, you can see that the selector variable remains constant:

Chatrooms.before.find(function (userId, selector) {
  let newSelector =
  {
    $or:[
      {
        ... selector,
        userGroupId : "USER_GROUP_ID",
      },
      {public:true}
    ]
  }
  
  // Delete all existing keys
  for (let key in selector) {
    if (selector.hasOwnProperty(key)){
        delete selector[key];
    }
  }
  
  // Copy all fields to the object
  for (let key in newSelector) {
    if (newSelector.hasOwnProperty(key)){
        selector[key] = newSelector[key];
    }
  }

  console.log("before",selector);
})

logs:

[tillk9]

Thanky you! Your ugly workaround is much less ugly than mine and still useful to me. :)