Yoroi not detected

Question

Yoroi not detected

magick93 opened this issue a year ago · comments

magick93 commented a year ago

Hello

What wallets are detected?

I have Yoroi and Yoroi Nightly installed, yet when I go to https://meshjs.dev/apis/browserwallet neither are detected.

magick93 · Answer 1 · Mon Feb 27 2023 16:15:44 GMT+0800 (China Standard Time)

Hi @Gns7077DEV - isnt the issue due to this PR not being merged - #48 ?

magick93 · Answer 2 · Mon Feb 27 2023 16:26:16 GMT+0800 (China Standard Time)

@jinglescode - please see above. This guy is trying to promote a scam site.

Hong Jing (Jingles) · Answer 3 · Tue Feb 28 2023 10:28:25 GMT+0800 (China Standard Time)

Hey @magick93, thanks for reporting. For Yorio, I am not detecting it either. But I would like you to do something and confirm with me.

open a browser tab, with that browse that has Yoroi installed
right click and inspect element
go to Console tab
type window.cardano
see what wallets are "found"

magick93 · Answer 4 · Tue Feb 28 2023 11:00:36 GMT+0800 (China Standard Time)

HI @jinglescode

This is what I get:

magick93 · Answer 5 · Tue Feb 28 2023 11:01:32 GMT+0800 (China Standard Time)

@jinglescode - is the problem that yoroi is missing from this list? https://github.com/MeshJS/mesh/blob/main/packages/module/src/common/constants.ts#L481-L483

Hong Jing (Jingles) · Answer 6 · Wed Mar 01 2023 09:45:32 GMT+0800 (China Standard Time)

@magick93. Your screenshot is good, this meansyoroi is on your device. And yes, we just have to add yoroi into SUPPORTED_WALLETS.

magick93 · Answer 7 · Wed Mar 01 2023 09:58:19 GMT+0800 (China Standard Time)

Thanks @jinglescode - I've added a PR - #105

Abdelkrim Dib · Answer 8 · Wed Mar 01 2023 23:12:12 GMT+0800 (China Standard Time)

Hi, @magick93 unfortunately Yoroi doesn't fully support the CIP-30 specs.
Adding yoroi to the array of supported wallets isn't enough 😅
we have to make changes to the BrowserWallet class too