New items and directories are added above "parent dir" row

Question

New items and directories are added above "parent dir" row

joshas opened this issue 4 years ago · comments

Commit 43d93a9 introduced an issue: create file and create directory commands add new items above "parent dir" [..] item:

New files created in other file managers also appear on top.

Mladen Mijatov · Answer 1 · Wed Oct 07 2020 09:01:35 GMT+0800 (China Standard Time)

Yes, noticed that myself as well. Thanks for reporting. Basically new approach with sorting is to have custom hidden column which is populated with data which GTK can use to sort items. Issue with this is that generate_sort_data is not called when adding new item so it ends up with empty data for sorting and GTK just puts it at top.

In addition to calling said method we should also modify it to support dedicated iter_list which can be provided to allow us to generate sort data only for few items and not whole list.

joshas · Answer 2 · Sun Oct 25 2020 03:02:27 GMT+0800 (China Standard Time)

#489 fixed the issue.

Mladen Mijatov · Answer 3 · Sun Oct 25 2020 06:02:09 GMT+0800 (China Standard Time)

Thanks for closing the issue.

…

On Sat, Oct 24, 2020, 21:02 joshas ***@***.***> wrote: #489 <#489> fixed the issue. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#464 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOSWKU4ECGPSPXZ7P262MTSMMQE7ANCNFSM4SGQKDTQ> .