MauriceConrad / Photon

Clone native desktop UI's like cocoa and develop native feeling applications using web technologies

Home Page:https://mauriceconrad.github.io/Photon/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Vibrancy issue

Nivl opened this issue · comments

I tried using vibrancy (light) on a panel, but it doesn't seem to be working: the panel appears white-ish instead (but fully opaque). I tried running the ShowReel demo, and it's the same, everything looks white, including the modal (and clicking around made my CPU go 200%+).

data-vibrancy also doesn't seem to be doing anything. The following snippet works when setting vibrancy to light in the option of BrowserWindow but doesn't (= appears white) when using the data-vibrancy prop of ph-window:

<ph-window>
    <window-content>
        <nav-group>
            <nav-item>connors</nav-item>
            <nav-item>Downloads</nav-item>
            <nav-item>Documents</nav-item>
            <nav-item>AirPlay</nav-item>
            <nav-item>Applications</nav-item>
            <nav-item>Desktop</nav-item>
        </nav-group>
    </window-content>
</ph-window>

Then when using a sidebar (or any panel) with BrowserWindow's vibrancy option, the sidebar turns white but the right side does has vibrancy.

      <ph-window>
        <window-content>
          <div className="pane-group">
            <div className="pane-sm sidebar">
              <nav-group>
                <nav-item>connors</nav-item>
                <nav-item>Downloads</nav-item>
                <nav-item>Documents</nav-item>
                <nav-item>AirPlay</nav-item>
                <nav-item>Applications</nav-item>
                <nav-item>Desktop</nav-item>
              </nav-group>
            </div>
        </window-content>
      </ph-window>

Here's a screenshot of ShowReel, which doesnt look as it should be (tested with electron 3.0.10).

screen shot 2018-11-23 at 2 57 10 am

Hm, I tested it with the newest electron release and found the following issues:

  1. If you do not use the Developer-Tools (or in a second window), the sidebar appears vibrancy on macOS mojave 10.14.2
  2. A dialog currently has no vibrancy.

The bug did not happened before in earlier electron versions. I will try to fix it soon as possible...