Make `rpc` handlers abstract arrow function properties.

Question

Make `rpc` handlers abstract arrow function properties.

tegefaulkes opened this issue a year ago · comments

Specification

Currently the rpc handlers are abstract methods that need to be implemented. These should be an abstract arrow function property and handlers should be implemented as arrow functions. This will allow us to use them without rebinding the this context.

This should be done during the agent migration PR.

Additional context

Should be done during MatrixAI/Polykey#512
Related MatrixAI/Polykey#509 .

Tasks

Update the abstract handler's handle methods to be abstract arrow function properties.

Roger Qiu · Answer 1 · Fri Aug 18 2023 15:53:59 GMT+0800 (China Standard Time)

This is moved here as updating this in js-rpc will force the adoption of it in Polykey when it updates.

Aditya · Answer 2 · Wed Sep 13 2023 09:05:47 GMT+0800 (China Standard Time)

Resolved in #8

Brian Botha · Answer 3 · Wed Sep 13 2023 10:59:48 GMT+0800 (China Standard Time)

You need to re-open this. It should be closed automatically by #8 being merged.

Roger Qiu · Answer 4 · Wed Sep 13 2023 11:37:16 GMT+0800 (China Standard Time)

@addievo this issue is not fixed in your PR #8. You need to change the classes to specify that handlers should a be an arrow property and add tests into the RPC to be make it to be the case.

I'm not sure if class methods even satisfy arrow property types, and vice versa.