Feature: using tailwind-merge library to override parent classes

Question

Feature: using tailwind-merge library to override parent classes

bcucumber opened this issue 3 years ago · comments

Hi! First of all, this is a great library as it makes working with Tailwind a lot easier, and I'm very thankful for that.

Like the documentation explains, this library doesn't override parent classes, it just concatenates the different classes and the result will depend on each case. Which brings to the following suggestion: how possible would it be to switch the use of the current library tailwindcss-classnames to tailwind-merge (https://github.com/dcastil/tailwind-merge) as this other library already handles tailwind classes overriding?

I understand that this might be a breaking change given the current state of the library (if it's a hard change, but maybe it could be configurable?). However I believe users would benefit a lot more if it were possible to override parent classes.

Thanks!

Mathias Gilson · Answer 1 · Tue Mar 22 2022 02:59:45 GMT+0800 (China Standard Time)

Great idea! I'll have a look, PR are welcome if you have time 😉

Coco · Answer 2 · Sun Mar 27 2022 02:45:28 GMT+0800 (China Standard Time)

Hi @MathiasGilson, I submitted a PR with the changes for this feature. Feel free to check it out and run the checks on your end whenever you can!

Mathias Gilson · Answer 3 · Sun Mar 27 2022 02:55:32 GMT+0800 (China Standard Time)

Will do! Thank you so much for taking the time to do it 😉

Mathias Gilson · Answer 4 · Tue Mar 29 2022 05:56:01 GMT+0800 (China Standard Time)

Implemented in the last version 2.1.6!

Thank you for your PR!