`20221209-update-renovatejson-v4` tag does not fail NewVersion test

Question

`20221209-update-renovatejson-v4` tag does not fail NewVersion test

bcbrockway opened this issue a year ago · comments

Hi all, our ArgoCD Image Updater randomly changed one of our prod tags from v1.10.0 to a branch image - 20221209-update-renovatejson-v4. They use the NewVersion function (here) and we should probably petition them to add an option to use StrictNewVersion but should NewVersion really be accepting that tag as a valid semver?

Matt Farina · Answer 1 · Fri Feb 24 2023 06:29:27 GMT+0800 (China Standard Time)

@bcbrockway it looks like you found a bug.

Matt Farina · Answer 2 · Tue Apr 04 2023 04:34:09 GMT+0800 (China Standard Time)

It turns out I was wrong. From the spec:

Identifiers MUST comprise only ASCII alphanumerics and hyphens [0-9A-Za-z-]

If you read the grammar you'll find the - explicitly listed for the <non-digit> cases.

A - is allowed. So, NewVersion should parse 20221209-update-renovatejson-v4 as valid while StrictNewVersion should provide an error.