Giters

MasoniteFramework / masonite

The Modern And Developer Centric Python Web Framework. Be sure to read the documentation and join the Discord channel for questions: https://discord.gg/TwKeFahmPZ

Home Page:http://docs.masoniteproject.com

Repository from Github https://github.comMasoniteFramework/masoniteRepository from Github https://github.comMasoniteFramework/masonite

Validation decorator isn't working

tpow opened this issue · comments

commented

Describe the bug

In Masonite 3, the validation decorators were documented. However, I don't see them in the documentation for v4.0. Was this intentional?

It looks like the decorator is still included. However, it definitely has a bug:

from wsgi import container

needs to change to

 from wsgi import application as container

or rename container to application throughout validation/decorators.py

The decorators are handy, however I could switch if they are intentionally removed. At the moment they cause mysterious failures after trying to upgrade my project from 3 to 4.

Expected behaviour

No response

Steps to reproduce the bug

No response

Screenshots

No response

OS

Linux

OS version

Ubuntu LTS

Browser

No response

Masonite Version

4.17.4

Anything else ?

No response

commented

checked into this. the decorator logic was dropped in 4.0 because it needded to be built like crap to work and made it difficult to maintain and test. i'd be open for a better implementation of it in Masonite 5 but its not supported anymore