Broken json after re-adding a completed task

[Csaba Endre Simon]

Steps to reproduce:

cargo run -- add "make coffee"
cargo run -- complete "make coffee"
cargo run -- add "make coffee"

cat db.json
{
"make coffee": true
}}

Observe the two closing brackets at the end of the file.

This happens because the file is not truncated when writing. The "true" is one character lesser than "false" and the last closing brackets remains in place. To fix in "fn save(self)" the file OpenOptions should contain the .truncate(true) method also.

[Claudio Restifo]

Hi @secsaba, thanks for reporting, and finding the solution to the issue.
Great job!

Do you want to contribute by submitting a PR?
No worries if you can't, I will take care of it.

Thanks for your help on this! 👍

[Csaba Endre Simon]

Yes, I would like to submit a PR. As I didn’t created any PR, give me some time to figure out how to do it. Thanks, Csaba

…

On 2021. Jan 7., at 9:33, Claudio Restifo ***@***.***> wrote: Hi @secsaba <https://github.com/secsaba>, thanks for reporting, and finding the solution to the issue. Great job! Do you want to contribute by submitting a PR? No worries if you can't, I will take care of it. Thanks for your help on this! 👍 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAVAD5SNNZB5LWG7J4CWEM3SYVWUFANCNFSM4VXU3XLA>.

[Claudio Restifo]

Incidentally freeCodeCamp has a guide on how to do it.

Take your time, and if you need help just shout out and I'll try to help 👍

[Claudio Restifo]

Your change is now merged into the source code: well done on your first PR. 🥳