IE search strategy no longer returned when OS_DEFAULT strategy used on Windows

Question

IE search strategy no longer returned when OS_DEFAULT strategy used on Windows

jpasski opened this issue 7 years ago · comments

In proxy-vole 1.0.3, the IE search strategy is added when the OS_DEFAULT search strategy is used on Windows. In proxy-vole 1.0.4, the strategy is not added when OS_DEFAULT is used. Is this expected behavior?

Drew Mitchell · Answer 1 · Thu Oct 05 2017 07:19:40 GMT+0800 (China Standard Time)

That's correct. In 1.0.3 and earlier, the WinProxySearchStrategy just replicated the IEProxySearchStrategy. The original author left a TODO back in 2009 to implement it with Windows API calls. I did so in 62b129a, which was included in 1.0.4. Now, you can use the Windows strategy to find proxy settings in the registry and the IE strategy for proxy settings at the user level like before.

Markus Bernhardt · Answer 2 · Thu Oct 05 2017 19:14:45 GMT+0800 (China Standard Time)

Shouldn't we have in Win and IE Stratege as OS_DEFAULT? Von meinem iPhone gesendet

…

Am 05.10.2017 um 01:19 schrieb Drew Mitchell ***@***.***>: That's correct. In 1.0.3 and earlier, the WinProxySearchStrategy just replicated the IEProxySearchStrategy. The original author left a TODO back in 2009 to implement it with Windows API calls. I did so in 62b129a, which was included in 1.0.4. Now, you can use the Windows strategy to find proxy settings in the registry and the IE strategy for proxy settings at the user level like before. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Jonni Passki · Answer 3 · Thu Oct 05 2017 21:58:46 GMT+0800 (China Standard Time)

Thanks for the background @nerdydrew. As a recent consumer of the library, I was surprised by the change. I could see others who have been using this, or the previously maintained, version of the library surprised also. This is especially true if it has been the default for the last 7-8 years. Since the above change will break those existing consumers who do not explicitly add the IE strategy and who upgrade to 1.0.4, I recommend documenting the change more prominently and perhaps bumping the version number to 1.1.

@MarkusBernhardt I'm unfamiliar with Windows, however, I could see the usefulness of allowing users to choose exclusively between the registry settings or the IE settings. I'm using the library with an intercepting proxy tool called Burp that's used in web application security assessments. I could see it being useful to reconfigure IE to go through Burp only leaving the desktop settings in place.