Angular 2 compatibility

Question

Angular 2 compatibility

tisto opened this issue 8 years ago · comments

Timo Stollenwerk commented 8 years ago

@emanlove Any plans to make this plugin work with Angular 2?

Ed Manlove · Answer 1 · Sun Nov 13 2016 00:03:45 GMT+0800 (China Standard Time)

@tisto I don't work with angular2 yet but I can look into making it angular 2 compatible.

Timo Stollenwerk · Answer 2 · Mon Nov 14 2016 16:38:40 GMT+0800 (China Standard Time)

@emanlove that would be awesome! Let me know if there is anything I can do to help.

dh-lex · Answer 3 · Thu Dec 22 2016 22:13:04 GMT+0800 (China Standard Time)

@emanlove any updates on this? Would portions of this library still be compatible?

Ed Manlove · Answer 4 · Tue Jun 06 2017 21:17:05 GMT+0800 (China Standard Time)

@dh-lex, @tisto: I am starting to look at this again as I have an Angular2 app that needs this. I need it to be compatible with both Angular 1 as well as Angular 2 and 3 (or 2+) I plan on making that work. And relooking at protractor I think this is done within a single Protractor library which works for both 1 and 2+ so this might be a little straight forward (hopefully!)

Ed Manlove · Answer 5 · Tue Jun 06 2017 23:53:39 GMT+0800 (China Standard Time)

So looking at the current state of Protractor I could move in some form of the waitForAngular function. What is causing me to think is the callbacks. If one reads through my write-up on the self testing of the AngularJS library one will see that I use python execute_script instead of execute_async_script for a couple reasons. But this then blocks and so I have been considering how to make this async. The question I have is what to do first. I think I am going to put this Angular 2+ code into the method I currently have with the synchronous call and then tackle the other issue of async vs sync.

Ed Manlove · Answer 6 · Thu Jun 08 2017 02:27:30 GMT+0800 (China Standard Time)

@dh-lex @tisto Initial commit [9ac7bdc] for Angular 2 support. I have written up some more notes on the development and testing of these changes under TESTING.rst. Preliminary tests are not good as the implicit waits are timing out. I am thinking this may be due to the model used for Angular 1 and notifyWhenNoOutstandingRequests does not work for getAngularTestability. Or it could be some other factor(s).

Ed Manlove · Answer 7 · Fri Jun 09 2017 03:10:16 GMT+0800 (China Standard Time)

@tisto Is there a public Plone site that is running Angular 2 that I can try out some AngularJSLibrary changes against?

Timo Stollenwerk · Answer 8 · Sat Jun 10 2017 02:30:38 GMT+0800 (China Standard Time)

There is https://kitconcept.com/blog. Though, we use server-side rendering there. Not sure if that makes a difference for your library checks. cc @sneridagh

Ed Manlove · Answer 9 · Sat Jun 10 2017 06:40:42 GMT+0800 (China Standard Time)

I have cut the 0.0.5 release with Angular 2+ support. This is using the window.getAngularTestibility() function. It does not though support window.getAllAngularTestabilities() nor, what I believe to be AngularJS functionality, window.angular.getTestibility(). I am still trying to understand all these apis. Also the root selector is hard coded as [ng-app] so I am going to work on this issue [#16] next. If anyone gets a chance to try it out on their sites I would be interested in your experience. And note again you may need to change the root selector.