UI errors on dark theme switch
Discostu36 opened this issue · comments
Vespucci Version
19.3.4
Download source
Google Play
Device (Manufacturer and Model)
Fairphone 4
Android Version
13
Behaviour/Symptoms
When the system theme switches from dark to bright at sunrise while Vespucci is open, there are some interface color errors, like this one from the changeset comment suggestions:
Expected Behaviour
Flawless switching of themes
How to recreate
I guess this can be recreated by manually switching system theme from dark to bright.
Crash dump submitted (no or yes + date)
No
Any other potentially relevant information
This is not unexpected, we currently force activities to recreate, but don't do anything special for DialogFragments (the upload modal is one), and it isn't even really clear what would work.
I guess this can be recreated by manually switching system theme from dark to bright.
Unluckily not, manually changing the system theme in the device settings doesn't call the onConfigurationChange callback in the activities. This might actually be an Android version related change that the behaviour is now different, in any case I can trigger a theme switch correctly now.
The interesting thing is after I've fixed the issue with detecting the theme change, things seem to work as expected: