Crashes when hitting "Upload data to OSM server"
vespucci-reporter opened this issue · comments
Description:
The app crashes everytime I hit the upload button. I've made 502 changes (which is now really frustrating). My changes are still cached, which I at least appreciate, but it doesn't help that I can't push them regardless.
I presume it's not due to the server upload process since that happens after I approve it and add the notes. My guess is it's when it tries to render 500 change items..?
Worse, I can't even export an OSC file. The button is disabled (wth?).
My only other option for uploading appears to be manually copying every change to the browser editor which actually does work.
Now, I get that 500 changes is probably too many. But if so, the app is still at fault for letting me even make that many changes before requiring upload.
If nothing else, PREVENT a user from making more than however many changes it takes to break the app, and require them to upload before proceeding.
Thx. I am also a developer. If this app is open sourced, I would consider contributing, even if just for my own sanity..
Device info:
| App version | 17.1.2.0 |
| App version code | 2103 |
| Android build version | G970U1UES8IWD3 |
| Android release version | 12 |
| Android SDK version | 31 |
| Android build ID | SP1A.210812.016.G970U1UES8IWD3 |
| Device brand | samsung |
| Device manufacturer | samsung |
| Device name | beyond0q |
| Device model | SM-G970U1 |
| Device product name | beyond0qlteue |
| Device hardware name | qcom |
| ABIs | [arm64-v8a, armeabi-v7a, armeabi] |
| ABIs (32bit) | [armeabi-v7a, armeabi] |
| ABIs (64bit) | [arm64-v8a] |
Extra info:
| OSM display name | cs32 |
There is no limit at 500 changes or similar, you can make 1000s of edits and should be able to upload them.
Unluckily you are using quite an old version which limits the options that we have to find out what is going on a bit (NOTE: don't upgrade before we've done more investigation).
Have you previously been able to upload and did you submit a crash dump?
Further: from where did you obtain the app?
Hey @simonpoole,
Thanks for the response! It's 'cs32'. I didn't realize my report would post on GitHub until I submitted it. Otherwise, I'd probably have signed in to report.
I ended up manually transcribing the changes to the online OSM iD editor, and uploaded it that way.
I then updated the app after that, since it didn't matter if I lost the changes, but to my delight, they actually still held. I cleared them out anyway, since I already submitted them, but before that, I tried starting the process of submitting to see if it worked, and it did not crash. So, my guess is, either it was some kind of overload of cache, or it was a bug that has long been fixed.
Either way, I do think this issue can be closed, as it was most likely an issue that has been fixed, or otherwise cannot be tested at this point. But if it does happen again, with the new version, I'll try to do more diagnosis, and report it again.
Thanks!
What is weird, besides the crash, is that saving as an ocs file was disabled as that is only the case when the datastructure holding edits is empty, if that is the case you can't upload either.
As you can imagine the upload functionality is one of the best exercised bits of the app and something systematically there not working would immediately lead to massive complaints.
Just to be sure when the crash happened, were you asked to submit a crash dump or not?
I believe so. If I can recall what it said.. something like, "Error occurred: This app has crashed. Hit OK to submit an error report, and please add any other relevant notes below."
It happened three or four times. Note, I did not check to see if "Export OCS" was enabled before the first crash. Only after the second or third try, I considered if there was another way of getting the changes uploaded.
So I located the crash dump (since I'm on vacation that took a sec), the crash was caused by pre-upload validation, and I'm fairly sure fixed in https://github.com/MarcusWolschon/osmeditor4android/blob/master/CHANGELOG.txt#L257
One node ways... Right! Good to hear that issue was fixed. I may have had a single point road or building accidentally while trying to do certain things.
UX suggestions, and possibly the cause:
At one point I was trying really hard to split one building into two. e.g.,
I would expect to be able to split two points on the way, and then it becomes two separate loops, kind of like in Illustrator. But I tried cut/pasting the points of the one building half, only to find myself with a bunch of disconnected points (really not very helpful). I believe I deleted them all, but maybe not?
At another point (the issue was more likely due to this), I was trying to switch which road name a segment of street belonged to (took me around 10mins...). It was connected to one road way, but should've been connected to the other road way. e.g.:
I was at first able to split the old road with the scissors, but I couldn't figure out how to join to the new road. Then, after undoing, I think the scissor tool stopped showing up, so I tried using the (useless?) "Extract node" button instead, which didn't help (https://github.com/MarcusWolschon/osmeditor4android/blob/master/svg/extract_node_light.svg). This may have left me with a one-node way?
Maybe doing things like this are easier in the new version? I haven't tried yet. But if not, please advise.
Thanks again for digging in @simonpoole!
At one point I was trying really hard to split one building into two. e.g.,
There is already a split in to two polygon function that does exactly that.
At another point (the issue was more likely due to this), I was trying to switch which road name a segment of street belonged to (took me around 10mins...). It was connected to one road way, but should've been connected to the other road way. e.g.:
Split the longer way, then select the segment of that way that you want to merge and the short way, select merge. Note that you will potentially need to fix the tags of the resulting way.
There are other ways to do this, but using the multi-select merge is the most universal.
There is already a split in to two polygon function that does exactly that.
Ok, got it, I just tried it out and, after awhile, I see how it works now.
Split the longer way, then select the segment of that way that you want to merge and the short way, select merge. Note that you will potentially need to fix the tags of the resulting way.
Again, I also just tried it and finally figured out all the steps involved.
A few recommendations now that I understand the source of my struggles using the tools:
I come from a background using Illustrator; so I'm very used to certain behaviors not available here.
I'm used to being able to select two points, hit a button, and then they join. I think, for a single path, turning a line into a polygon, this would be intuitive. It would also be cool to see this for merging two different features, providing the multi-select merge as you mentioned.
I'm also used to being able to pick a single point and break the connection at that point. Now, this already exists here for separately 'joined' features, but I cannot cut a single feature into two pieces (with the scissors) by first selecting the node to cut at. I have to select the whole way, then hit the scissors, and then pick the single point. But I think it makes a lot of sense to be able to pick a single node and break it, first by separating any 'joined' features at the spot, but afterward by splitting the feature itself (turning a polygon into a line, or a line into two lines).
Also, please forgive me, but what is the usefulness of the 'extract node' tool? It's only ever caused me major issues and confusion (like this whole thread...). Maybe it's really useful and I don't understand it, but if I need to add a point, I just hit the green (+) and "Add tagged node". I've never needed to 'extract' a single point from a line or way..
Lastly, minor concern: The first time I used the app, it wasn't very clear to me that the help button from the three-dots menu is contextual. I read the one page and thought that was everything, without realizing there was a hamburger menu with many other articles. Perhaps clarify this?
So, fwiw, that's been my user experience. But I do appreciate your tips which ultimately guided me to understand why the tools work the way they do.
Great app though! Thanks @simonpoole