modularize code
hokiegeek2 opened this issue · comments
Hi Everyone,
This algorithm works really well and we'll be using it in production. To that end, I wanted to modularize the code and add corresponding unit tests to make it easier to enhance this excellent implementation of the Twitter algorithm.
@Marcnuth Pull request coming soon
--John
Do you plan on improving the anomaly_detect_vec
function? Your fork doesn't seem to work when reindexing is required because of too small a granularity.
Hi @JonnoFTW I can take a look, please provide more information including the parameters and the test file(s) you tried.
@hokiegeek2 my data is private, so I'll have to send it to you privately. The code is here: https://github.com/JonnoFTW/incident_detection_eval/blob/master/sesd.py
Is your email your github user name @gmail.com? If so I'll send you the data there.