Giters

Mando75 / typeorm-graphql-loader

A query builder to easily resolve nested fields and relations for TypeORM-based GraphQL servers

Home Page:https://gql-loader.bmuller.net

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Redundant typeof BaseEntity typing

Defus-E opened this issue · comments

commented

I noticed that both GraphQLDatabaseLoader and GraphQLQueryBuilder use generic extending typeof BaseEntity which is incorrect in some cases because Entity might not be extended from BaseEntity. It enables some difficulties to implement correct typing in real use. It seems everything works great if entity isn't extended from BaseEntity, so I think it's redundant typing. Please, fix it.